Skip to content

[ZEPPELIN-1309] Show checkbox for "Connect to existing process" on interpreter menu. #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astroshim wants to merge 4 commits into from
Closed

[ZEPPELIN-1309] Show checkbox for "Connect to existing process" on interpreter menu. #1229

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbc3283
show checkbox on interpreter menu.
Jul 26, 2016
47ce719
remove height style on the checkbox
Jul 29, 2016
17fb0d7
change size to px
Aug 4, 2016
4b3673a
add css to interpreter-create page
Aug 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions zeppelin-web/src/app/interpreter/interpreter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@ <h5>Option</h5>
<br />
<div class="col-md-12">
<div class="checkbox">
<span class="input-group">
<label><input type="checkbox" style="width:0%;height:0%" id="isExistingProcess" ng-model="setting.option.isExistingProcess" ng-disabled="!valueform.$visible"/>
<span class="input-group" style="line-height:30px;">
<label><input type="checkbox" style="width:10%;height:70%" id="isExistingProcess" ng-model="setting.option.isExistingProcess" ng-disabled="!valueform.$visible"/>
Copy link
Contributor

@corneadoug corneadoug Jul 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole style (width and height), can actually be removed from here

Copy link
Contributor Author

@astroshim astroshim Jul 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for giving your advice.
You mean the style="line-height:30px;" can be removed?

Copy link
Contributor

@corneadoug corneadoug Jul 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this one is needed.
On the line under style="width:10%;height:70%"

Copy link
Contributor Author

@astroshim astroshim Jul 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay i see. I think height can be removed but width can not be removed.
because if remove width and height both, the screen is following like.
image
so I think width is needed. What do you think?

Connect to existing process </label>
</span>
</div>
Expand Down