Skip to content

Conversation

@AhyoungRyu
Copy link
Contributor

@AhyoungRyu AhyoungRyu commented Jul 20, 2016

What is this PR for?

As new interpreter registration mechanism which was started in ZEPPELIN-804, we can't set default interpreter anymore using zeppelin-site.xml as described in https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration (see zeppelin.interpreters property description in the configuration table). So we need to remove the related contents in Zeppelin docs site.

Below pages will be updated:

What type of PR is it?

Documentation

What is the Jira issue?

ZEPPELIN-1209

How should this be tested?

No need to test. Just removed two sentences about the default interpreter setting.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@AhyoungRyu
Copy link
Contributor Author

@zjffdu @jongyoul Could you review this one? :)

@jongyoul
Copy link
Member

@AhyoungRyu Thanks for the quick fix. Could you please add the description about Deprecated of this feature? I have a plan to remove its dependency until 0.7.0. Except that, LGTM

@AhyoungRyu
Copy link
Contributor Author

@jongyoul Yeah I added the description to zeppelin.interpreters cell in the configuration table as you said. So it would be like this:

  • Before
    screen shot 2016-07-20 at 5 08 23 pm
  • After
    screen shot 2016-07-20 at 5 08 16 pm

@jongyoul
Copy link
Member

Thanks @AhyoungRyu. Merging if there's no more discussion

@AhyoungRyu
Copy link
Contributor Author

CI build failure is irrelevant with this PR i think. Can this be merged then?

asfgit pushed a commit that referenced this pull request Aug 3, 2016
…ter in docs

### What is this PR for?
As new interpreter registration mechanism which was started in [ZEPPELIN-804](https://issues.apache.org/jira/browse/ZEPPELIN-804), we can't set default interpreter anymore using `zeppelin-site.xml` as described in [https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration) (see `zeppelin.interpreters` property description in the configuration table). So we need to remove the related contents in Zeppelin docs site.

Below pages will be updated:
 - [https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration)
 - [https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelininterpreter.html#060-and-later](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelininterpreter.html#060-and-later)

### What type of PR is it?
Documentation

### What is the Jira issue?
[ZEPPELIN-1209](https://issues.apache.org/jira/browse/ZEPPELIN-1209)

### How should this be tested?
No need to test. Just removed two sentences about the default interpreter setting.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <fbdkdud93@hanmail.net>

Closes #1207 from AhyoungRyu/ZEPPELIN-1209 and squashes the following commits:

61108f4 [AhyoungRyu] Add a sentence about the deprecation
9f44f22 [AhyoungRyu] Remove useless sentence about default interpreter in docs

(cherry picked from commit 16b320f)
Signed-off-by: Jongyoul Lee <jongyoul@apache.org>
@asfgit asfgit closed this in 16b320f Aug 3, 2016
PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
…ter in docs

### What is this PR for?
As new interpreter registration mechanism which was started in [ZEPPELIN-804](https://issues.apache.org/jira/browse/ZEPPELIN-804), we can't set default interpreter anymore using `zeppelin-site.xml` as described in [https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration) (see `zeppelin.interpreters` property description in the configuration table). So we need to remove the related contents in Zeppelin docs site.

Below pages will be updated:
 - [https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration)
 - [https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelininterpreter.html#060-and-later](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelininterpreter.html#060-and-later)

### What type of PR is it?
Documentation

### What is the Jira issue?
[ZEPPELIN-1209](https://issues.apache.org/jira/browse/ZEPPELIN-1209)

### How should this be tested?
No need to test. Just removed two sentences about the default interpreter setting.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <fbdkdud93@hanmail.net>

Closes apache#1207 from AhyoungRyu/ZEPPELIN-1209 and squashes the following commits:

61108f4 [AhyoungRyu] Add a sentence about the deprecation
9f44f22 [AhyoungRyu] Remove useless sentence about default interpreter in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants