[Zeppelin-1161] Revert precise execution time #1172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@corneadoug Wasn't it intended behaviour because of #862 (comment)? Anyway I prefer to show the precise execution time even if it shows such as |
Contributor
Author
|
@AhyoungRyu No, that discussion was about the elapsed time. |
Contributor
Author
|
@AhyoungRyu Made modifications and added screenshot |
Contributor
|
@corneadoug more graceful! Thanks for taking care of this 👍 |
Contributor
|
@corneadoug When I build this PR in my local, i got this jscs warnings.
|
Contributor
Author
|
I'm not sure why CI is not green, triggering it once more |
corneadoug
force-pushed
the
ZEPPELIN-1161
branch
from
77ef3f6 to
df752bd
Compare
Contributor
|
@corneadoug Will this changes also be available in 0.6.1 ? |
Contributor
Author
|
@SachinJanani There should be a thread about 0.6.1. |
Contributor
|
@corneadoug Yes you are right. |
Member
|
Looks great to me, and CI is green now! |
Contributor
Author
|
Merging it now! |
asfgit
pushed a commit
that referenced
this pull request
Jul 19, 2016
### What is this PR for? It had been pointed out in the mailing list that after #862, the execution time was changed to humanized fashion, while we would want to keep something more precise in that case. This PR is rolling back to the old precise time for execution time. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1161 ### How should this be tested? Run a paragraph, after it is finished, it should show: `Took x seconds.` instead of `Took a few seconds` (or Hours, Minutes, Sec) ### Screenshot  ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <corneadoug@gmail.com> Closes #1172 from corneadoug/ZEPPELIN-1161 and squashes the following commits: df752bd [Damien CORNEAU] Add licence of new dependency 2c21894 [Damien CORNEAU] Fix jscs errors 9f756e3 [Damien CORNEAU] add moment plugin for duration 935f348 [Damien CORNEAU] Fix jxcs e4f7625 [Damien CORNEAU] Revert seconds ago for execution time (cherry picked from commit dbe5e6c) Signed-off-by: Mina Lee <minalee@apache.org>
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? It had been pointed out in the mailing list that after apache#862, the execution time was changed to humanized fashion, while we would want to keep something more precise in that case. This PR is rolling back to the old precise time for execution time. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1161 ### How should this be tested? Run a paragraph, after it is finished, it should show: `Took x seconds.` instead of `Took a few seconds` (or Hours, Minutes, Sec) ### Screenshot  ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <corneadoug@gmail.com> Closes apache#1172 from corneadoug/ZEPPELIN-1161 and squashes the following commits: df752bd [Damien CORNEAU] Add licence of new dependency 2c21894 [Damien CORNEAU] Fix jscs errors 9f756e3 [Damien CORNEAU] add moment plugin for duration 935f348 [Damien CORNEAU] Fix jxcs e4f7625 [Damien CORNEAU] Revert seconds ago for execution time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
It had been pointed out in the mailing list that after #862, the execution time was changed to humanized fashion, while we would want to keep something more precise in that case.
This PR is rolling back to the old precise time for execution time.
What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1161
How should this be tested?
Run a paragraph, after it is finished, it should show:
Took x seconds.instead ofTook a few seconds(or Hours, Minutes, Sec)Screenshot
Questions: