Skip to content

Conversation

@cloverhearts
Copy link
Member

@cloverhearts cloverhearts commented Jul 8, 2016

What is this PR for?

Job manger front side feature

sort by notebook name (asc/desc),
search for notebook(filtering)
filter by interpreter group.
run / stop to notebook.

It is created with the following additional functions PR.
(E. G., Filter and sort)

this PR is divided from the #921

What type of PR is it?

Improvement

Todos

  • sort by notebook name (asc/desc),
  • search for notebook(filtering)
  • filter by interpreter group.
  • run / stop to notebook.

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-531
https://issues.apache.org/jira/browse/ZEPPELIN-965
https://issues.apache.org/jira/browse/ZEPPELIN-966
https://issues.apache.org/jira/browse/ZEPPELIN-967
https://issues.apache.org/jira/browse/ZEPPELIN-968
https://issues.apache.org/jira/browse/ZEPPELIN-969
https://issues.apache.org/jira/browse/ZEPPELIN-970

Screen Shots

cap 2016-07-08 16-52-00-956

ScreenShots
and working video (animated gif)

How should this be tested?

  1. create and running, modified notebook and paragraph.
  2. check to cron or normal notebook status in job manager.
  3. use to filter featrue in jobmanagement page

    Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@corneadoug
Copy link
Contributor

@cloverhearts This needs to be fixed:
https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/jobmanager/jobmanager.controller.js#L82

We can't have the front-end call for refresh every x seconds, only the server should be sending that event to us through websocket.

@cloverhearts
Copy link
Member Author

@corneadoug
Thank you for your feedback, I'll solve the problem.

cloverhearts and others added 4 commits July 11, 2016 11:45
# Conflicts:
#	zeppelin-web/src/app/jobmanager/jobmanager.controller.js
#	zeppelin-web/src/app/jobmanager/jobs/job.controller.js
# Conflicts:
#	zeppelin-web/src/app/jobmanager/jobmanager.controller.js
@cloverhearts
Copy link
Member Author

i will divide this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants