Skip to content

Conversation

@Leemoonsoo
Copy link
Member

What is this PR for?

When notebook is being loaded, following error is raised after #836

Caused by: java.lang.NullPointerException
    at org.apache.zeppelin.notebook.Paragraph.getRepl(Paragraph.java:204)
    at org.apache.zeppelin.notebook.Paragraph.getCurrentRepl(Paragraph.java:208)
    at org.apache.zeppelin.helium.Helium.suggestApp(Helium.java:138)
    at org.apache.zeppelin.rest.HeliumRestApi.suggest(HeliumRestApi.java:83)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
    at org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
    ... 50 more

What type of PR is it?

Hotfix

Todos

  • - Fix

What is the Jira issue?

ZEPPELIN-732, ZEPPELIN-1075

How should this be tested?

Run Zeppelin and load any notebook. And see if there're unexpected exception raised.

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@bzz
Copy link
Member

bzz commented Jul 8, 2016

Looks good to me - with this guy I can bind the interpreter to the notebook without NPE.

Do not we have some Selenium tests doing so?

I'd like to merge ASAP as a hotfix.

@asfgit asfgit closed this in 8da3e23 Jul 8, 2016
PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
…agraph.getRepl(Paragraph.java:204)

### What is this PR for?
When notebook is being loaded, following error is raised after apache#836

```
Caused by: java.lang.NullPointerException
	at org.apache.zeppelin.notebook.Paragraph.getRepl(Paragraph.java:204)
	at org.apache.zeppelin.notebook.Paragraph.getCurrentRepl(Paragraph.java:208)
	at org.apache.zeppelin.helium.Helium.suggestApp(Helium.java:138)
	at org.apache.zeppelin.rest.HeliumRestApi.suggest(HeliumRestApi.java:83)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
	at org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
	... 50 more
```

### What type of PR is it?
Hotfix

### Todos
* [x] - Fix

### What is the Jira issue?
ZEPPELIN-732, ZEPPELIN-1075

### How should this be tested?
Run Zeppelin and load any notebook. And see if there're unexpected exception raised.

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <[email protected]>

Closes apache#1150 from Leemoonsoo/fix_npe and squashes the following commits:

10746f5 [Lee moon soo] adjust indentation
0471042 [Lee moon soo] Add unittest
3e8697b [Lee moon soo] Set interpreter factory into paragraph right after loaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants