[ZEPPELIN-1081] Extract spark.r setting from interpreter-setting.json on Spark interpreter mudule #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ready to review. This is related to #1077 |
jongyoul
changed the title
jongyoul
changed the title
Member
Author
|
I'll merge it into master and branch-0.6 |
asfgit
pushed a commit
that referenced
this pull request
Jun 30, 2016
… on Spark interpreter mudule ### What is this PR for? Avoid setting `spark.r` without `-Psparkr`. This enables to use `-Pr` correctly. ### What type of PR is it? [Bug Fix] ### Todos * [x] - Separate settings with profile ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1081 ### How should this be tested? 1. Build Zeppelin with `-Pr` 1. Run codes with R ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <[email protected]> Closes #1108 from jongyoul/ZEPPELIN-1081 and squashes the following commits: d7b7481 [Jongyoul Lee] Fixed not to include spark.r setting while not using -Psparkr (cherry picked from commit 4c66689) Signed-off-by: Jongyoul Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Avoid setting
spark.rwithout-Psparkr. This enables to use-Prcorrectly.What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
How should this be tested?
-PrScreenshots (if appropriate)
Questions: