Skip to content

Conversation

@minahlee
Copy link
Member

What is this PR for?

Apply margin-bottom: 20px on box class by removing home class

What type of PR is it?

Bug Fix

What is the Jira issue?

ZEPPELIN-1082

Screenshots (if appropriate)

Before
screen shot 2016-06-28 at 11 56 16 pm

After
screen shot 2016-06-28 at 11 56 48 pm

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@prabhjyotsingh
Copy link
Contributor

Tested, LGTM!

@AhyoungRyu
Copy link
Contributor

LGTM 👍

@astroshim
Copy link
Contributor

LGTM

1 similar comment
@corneadoug
Copy link
Contributor

LGTM

@prabhjyotsingh
Copy link
Contributor

Merging this if no more discussion.

@asfgit asfgit closed this in 3ae7d24 Jul 1, 2016
asfgit pushed a commit that referenced this pull request Jul 2, 2016
### What is this PR for?
Apply margin-bottom: 20px on `box` class by removing `home` class

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-1082](https://issues.apache.org/jira/browse/ZEPPELIN-1082)

### Screenshots (if appropriate)
**Before**
<img width="1280" alt="screen shot 2016-06-28 at 11 56 16 pm" src="https://cloud.githubusercontent.com/assets/8503346/16443219/554778b6-3d8c-11e6-884f-8a7024e5d3d1.png">

**After**
<img width="1280" alt="screen shot 2016-06-28 at 11 56 48 pm" src="https://cloud.githubusercontent.com/assets/8503346/16443239/6142ccc4-3d8c-11e6-914f-87f523bf8275.png">

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Mina Lee <minalee@apache.org>

Closes #1106 from minahlee/ZEPPELIN-1082 and squashes the following commits:

fcace59 [Mina Lee] Remove home class to make space between boxes

(cherry picked from commit 3ae7d24)
Signed-off-by: Mina Lee <minalee@apache.org>
@minahlee minahlee deleted the ZEPPELIN-1082 branch November 2, 2016 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants