Skip to content

[ZEPPELIN-921] Apply new mechanism to KnitR and RRepl #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rerngvit wants to merge 1 commit into from
Closed

[ZEPPELIN-921] Apply new mechanism to KnitR and RRepl #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions r/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@
<exclude>**/derby.log</exclude>
<exclude>**/metastore_db/</exclude>
<exclude>**/README.md</exclude>
<exclude>**/interpreter-setting.json</exclude>
<exclude>**/dependency-reduced-pom.xml</exclude>
</excludes>
</configuration>
Expand Down
6 changes: 0 additions & 6 deletions r/src/main/java/org/apache/zeppelin/rinterpreter/KnitR.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@
public class KnitR extends Interpreter implements WrappedInterpreter {
KnitRInterpreter intp;

static {
Interpreter.register("knitr", "spark", KnitR.class.getName(),
RInterpreter.getProps()
);
}

public KnitR(Properties property, Boolean startSpark) {
super(property);
intp = new KnitRInterpreter(property, startSpark);
Expand Down
6 changes: 0 additions & 6 deletions r/src/main/java/org/apache/zeppelin/rinterpreter/RRepl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@
public class RRepl extends Interpreter implements WrappedInterpreter {
RReplInterpreter intp;

static {
Interpreter.register("r", "spark", RRepl.class.getName(),
RInterpreter.getProps()
);
}

public RRepl(Properties property, Boolean startSpark) {
super(property);
intp = new RReplInterpreter(property, startSpark);
Expand Down
14 changes: 14 additions & 0 deletions r/src/main/resources/interpreter-setting.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
[
{
"group": "spark",
"name": "knitr",
"className": "org.apache.zeppelin.rinterpreter.KnitR",
"properties": null
},
{
"group": "spark",
"name": "r",
"className": "org.apache.zeppelin.rinterpreter.RRepl",
"properties": null
}
]