Skip to content

Conversation

@minahlee
Copy link
Member

What is this PR for?

This PR is applying new interpreter register mechanism to python interpreter.

What type of PR is it?

Improvement

What is the Jira issue?

ZEPPELIN-1045

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@minahlee
Copy link
Member Author

\cc @bzz @jongyoul for review

@bzz
Copy link
Member

bzz commented Jun 22, 2016

Looks great to me, thank you @minahlee !

Will merge, if there is no more discussion

@bzz
Copy link
Member

bzz commented Jun 22, 2016

BTW while we are here, how do you think shall we also set zeppelin.python.maxResult to 1000 in properties, propagate it to PythonInterpreter.java and document it (as with other interpreters)?

@minahlee
Copy link
Member Author

@bzz Good suggestion! This will be useful to display dataframe in table view. I addressed it in 66b8f73

@bzz
Copy link
Member

bzz commented Jun 23, 2016

Looks awesome to me, thank you!

I think it's ready to merge, if there is no further discussion

@asfgit asfgit closed this in ff4973d Jun 23, 2016
@minahlee minahlee deleted the ZEPPELIN-1045 branch July 22, 2016 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants