Skip to content

Conversation

@astroshim
Copy link
Contributor

What is this PR for?

This PR is to fix bug from #806.
The default interpreter name that automatically adds should be interpreter group name.

What type of PR is it?

Bug Fix

Screenshots (if appropriate)

  • before
    b
  • after
    a

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@AhyoungRyu
Copy link
Contributor

@astroshim Good catch indeed. LGTM 👍

@minahlee
Copy link
Member

LGTM

@jongyoul
Copy link
Member

Thanks for checking this out

@cloverhearts
Copy link
Member

good fix!

@Leemoonsoo
Copy link
Member

@astroshim could you rebase and see if it passes selenium test CI build profile?

@astroshim
Copy link
Contributor Author

@Leemoonsoo I rebased.

@astroshim
Copy link
Contributor Author

The selenium test has passed!!

@Leemoonsoo
Copy link
Member

@astroshim Now there're commits not belongs to this contributions, 41a7302, fd715c8, ab5ce62
Could you remove these commits?

@astroshim astroshim force-pushed the bugfix/ZEPPELIN-707 branch from 9fd7fa1 to 8e00b49 Compare June 22, 2016 23:25
@astroshim
Copy link
Contributor Author

@Leemoonsoo Sorry for late response. I fixed.

@Leemoonsoo
Copy link
Member

@astroshim No worries. Thanks for the quick response.
LGTM and merge into master branch if there're no more discussions.

@asfgit asfgit closed this in d779913 Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants