[ZEPPELIN-1033] HotFixing of paragraph deletion and re-ordering broken

[astroshim]

What is this PR for?

This PR is for fixing this issue

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1033

Questions:

• Does the licenses files need update? no
• Is there breaking changes for older versions? no
• Does this needs documentation? no

[randerzander]

@astroshim still getting same errors. After trying to "move up" and then "delete" a cell, I get these errors in the log: http://pastebin.com/Sr4WveXF

[astroshim]

@randerzander Thank you for your review. Let me check.

[astroshim]

@randerzander Did you build this PR?
You can get this PR from git clone https://github.com/astroshim/zeppelin -b ZEPPELIN-1033.
My zeppelin is working well as following screenshot.

Could you please check one more?

[AhyoungRyu]

It works as before 👍

[khalidhuseynov]

may need to remove import of Ini, doesn't seem to be used

[astroshim]

Thank you for your review. I removed importing Ini.

[khalidhuseynov]

I checked it, and behavior with paragraph reordering fixed. So basically, previously shiro was initialized only when needed from shiro.ini, and now it's initialized always when starting the server explicitly. to be honest, i'm not exactly sure at the moment about the best way to solve the issue with SecurityManager initialization, since previously it was also initialized (automatically through the classpath) but wasn't available (possibly because of not injecting correctly). But definitely this one way to solve the issue at the moment, which can be further improved

[randerzander]

I tried again from your branch and it worked. I must have applied your commit incorrectly last time.. my bad! Thanks for the fix =)

[astroshim]

nice @randerzander thanks for addressing this issue and review.

[Leemoonsoo]

+1 for merge

[minahlee]

Merging it as hotfix