ZEPPELIN-964 ] Jobmanagement - (2) basic front-end #1025

cloverhearts · 2016-06-16T10:26:16Z

What is this PR for?

Job manger basic front end.
You can check to paragraph and notebook information.
It is created with the following additional functions PR.
(E. G., Filter and sort)

this PR is divided from the #921

What type of PR is it?

Featrue

Todos

- notebook information
- viewing status for paragraph
- feat. running progress bar.
- added job menu in navbar.
(It can be modified by the following ([ZEPPELIN-1002] Move configuration menus under dropdown #1013)

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-964

How should this be tested?

create and running, modified notebook and paragraph.
check to cron or normal notebook status in job manager.

Screenshots

### Questions: - Does the licenses files need update? no - Is there breaking changes for older versions? no - Does this needs documentation? yes

astroshim · 2016-06-17T15:55:05Z

The job page looks greate and working good.
I think it seems to be better if the Job description is changed. :)
Then how can i control the the notebook action in the Job page?

cloverhearts · 2016-06-17T15:58:38Z

@astroshim
This PR is unable to control the Notebook.
Notebook control is ready for the next PR.

cloverhearts · 2016-06-17T16:00:43Z

@astroshim
check to sub-task section.
https://issues.apache.org/jira/browse/ZEPPELIN-531
Thank you.

astroshim · 2016-06-17T16:03:00Z

@cloverhearts Thanks for the quick response. I understand. 👍

AhyoungRyu · 2016-06-20T19:38:37Z

@cloverhearts Great feature indeed! 👍
It's minor thing but, it seems the first tooltip is not shown properly.

cloverhearts · 2016-06-20T19:41:50Z

@AhyoungRyu
Thank you for you feedback.
I'll fix that

Conflicts: zeppelin-web/src/components/navbar/navbar.html zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js

cloverhearts · 2016-06-28T08:12:23Z

merge from master branch and replace job menu location.

Leemoonsoo · 2016-06-28T14:10:28Z

IMO, 'Job' menu item can stay next to 'Notebook', instead of going into dropdown menu.
Because, "Interpreter', "Credential", "Configuration" menus are related configuring Zeppelin, and "Notebook", "Job" are related to using Zeppelin.

cloverhearts · 2016-06-29T05:17:14Z

@Leemoonsoo
Thank you for your feed back.
You are right.
I have completed modifications.

and
@AhyoungRyu fixed position for tooltip (top -> top-left)

jongyoul · 2016-07-02T15:05:23Z

ping

jongyoul · 2016-07-04T10:46:01Z

Is this PR completed?

cloverhearts · 2016-07-04T11:31:17Z

@jongyoul Yes, Completed.

jongyoul · 2016-07-04T11:35:45Z

It remains for the review, doesn't it?

cloverhearts · 2016-07-04T15:08:20Z

This PR is now completed.
In my opinion, it seems there is no problem.
Please merge after review.

Leemoonsoo · 2016-07-05T00:50:21Z

zeppelin-web/src/app/jobmanager/jobs/job.html

+      <a ng-switch-when="RUNNING"
+         style="text-decoration: none !important;"
+         ng-href="#/notebook/{{notebookJob.notebookId}}/paragraph/{{paragraphJob.id}}">
+        <i style="color: blue" class="fa fa-spinner spinAnimation"


In Chrome, it does not animate 'fa-spinner'. How about fa fa-spinner fa-spin to animate in chrome?

@Leemoonsoo
Add css code for the chrome browser
Thank you for your feedback.

chrome browser.

Leemoonsoo · 2016-07-05T00:58:14Z

Notebook list order in Job menu is different from notebook list in homepage and menu bar.

Notebook list in home page

Notebook list in job menu

If it list notebook in same order, it'll be much easier to find notebook in job menu.

cloverhearts · 2016-07-05T03:55:58Z

@Leemoonsoo
It seems you want to talk about sort Notebook name.
I dropped implemented it already, but it will be merged with the next step of the PR.
Attach the related links.

Jira issue (filter and name sort)
https://issues.apache.org/jira/browse/ZEPPELIN-967
Code (old PR)
https://github.com/apache/zeppelin/pull/921/files#diff-10471e430df1559157f6044bac4ca93dR44

Leemoonsoo · 2016-07-06T14:55:35Z

Thanks @cloverhearts for the new feature.
CI failure unrelated.
LGTM and merge if there're no more discussion.

### What is this PR for? Job manger basic front end. You can check to paragraph and notebook information. It is created with the following additional functions PR. (E. G., Filter and sort) this PR is divided from the apache#921 ### What type of PR is it? Featrue ### Todos - [x] - notebook information - [x] - viewing status for paragraph - [x] - feat. running progress bar. - [x] - added job menu in navbar. (It can be modified by the following (apache#1013) ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-964 ### How should this be tested? 1. create and running, modified notebook and paragraph. 2. check to cron or normal notebook status in job manager. ### Screenshots <img width="683" alt="job manger-basic" src="https://cloud.githubusercontent.com/assets/10525473/16113612/0120dec8-33f8-11e6-8dec-c74048fae637.png"> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? yes Author: CloverHearts <[email protected]> Author: CloverHearts <[email protected]> This patch had conflicts when merged, resolved by Committer: Lee moon soo <[email protected]> Closes apache#1025 from cloverhearts/dev/jobmanager/step/02-basic-front and squashes the following commits: aa7f502 [CloverHearts] Merge branch 'master' into dev/jobmanager/step/02-basic-front c759cff [CloverHearts] icon spin animation support for chrome. f183d73 [CloverHearts] job paragraph information tooltip top to top-left db76838 [CloverHearts] restore location for job menu in navbar bb8858c [CloverHearts] Merge branch 'master' into dev/jobmanager/step/02-basic-front 5d75520 [CloverHearts] Merge branch 'master' into dev/jobmanager/step/02-basic-front 0313cfa [CloverHearts] Merge branch 'master' into dev/jobmanager/step/02-basic-front baf3ec6 [CloverHearts] Merge branch 'master' into dev/jobmanager/step/02-basic-front 9ee539b [CloverHearts] Merge branch 'master' into dev/jobmanager/step/02-basic-front 5d64018 [CloverHearts] Merge branch 'master' into dev/jobmanager/step/02-basic-front 75186c7 [CloverHearts] implement basic - frontend for job manager. 18db280 [CloverHearts] modifed get run status for paragraph and bug fixed.

cloverhearts and others added 6 commits June 16, 2016 17:40

modifed get run status for paragraph and bug fixed.

18db280

implement basic - frontend for job manager.

75186c7

Merge branch 'master' into dev/jobmanager/step/02-basic-front

5d64018

Merge branch 'master' into dev/jobmanager/step/02-basic-front

9ee539b

Merge branch 'master' into dev/jobmanager/step/02-basic-front

baf3ec6

Merge branch 'master' into dev/jobmanager/step/02-basic-front

0313cfa

Merge branch 'master' into dev/jobmanager/step/02-basic-front

5d75520

Merge branch 'master' into dev/jobmanager/step/02-basic-front

bb8858c

Conflicts: zeppelin-web/src/components/navbar/navbar.html zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js

cloverhearts added 2 commits June 29, 2016 13:38

restore location for job menu in navbar

db76838

job paragraph information tooltip top to top-left

f183d73

Leemoonsoo reviewed Jul 5, 2016
View reviewed changes

cloverhearts added 2 commits July 5, 2016 12:45

icon spin animation support for chrome.

c759cff

Merge branch 'master' into dev/jobmanager/step/02-basic-front

aa7f502

cloverhearts closed this Jul 5, 2016

cloverhearts reopened this Jul 5, 2016

asfgit closed this in ca4e587 Jul 7, 2016

ZEPPELIN-964 ] Jobmanagement - (2) basic front-end #1025

ZEPPELIN-964 ] Jobmanagement - (2) basic front-end #1025

Uh oh!

Conversation

cloverhearts commented Jun 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Screenshots

Uh oh!

astroshim commented Jun 17, 2016

Uh oh!

cloverhearts commented Jun 17, 2016

Uh oh!

cloverhearts commented Jun 17, 2016

Uh oh!

astroshim commented Jun 17, 2016

Uh oh!

AhyoungRyu commented Jun 20, 2016

Uh oh!

cloverhearts commented Jun 20, 2016

Uh oh!

cloverhearts commented Jun 28, 2016

Uh oh!

Leemoonsoo commented Jun 28, 2016

Uh oh!

cloverhearts commented Jun 29, 2016

Uh oh!

jongyoul commented Jul 2, 2016

Uh oh!

jongyoul commented Jul 4, 2016

Uh oh!

cloverhearts commented Jul 4, 2016

Uh oh!

jongyoul commented Jul 4, 2016

Uh oh!

cloverhearts commented Jul 4, 2016

Uh oh!

Leemoonsoo Jul 5, 2016

Choose a reason for hiding this comment

Uh oh!

cloverhearts Jul 5, 2016

Choose a reason for hiding this comment

Uh oh!

Leemoonsoo commented Jul 5, 2016

Uh oh!

cloverhearts commented Jul 5, 2016

Uh oh!

Leemoonsoo commented Jul 6, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cloverhearts commented Jun 16, 2016 •

edited

Loading