[ZEPPELIN-1015] Cron job fails to run a paragraph when multiple type of interpreter is being used #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leemoonsoo
force-pushed
the
ZEPPELIN-1015
branch
from
0788641 to
f6e6143
Compare
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Leemoonsoo
force-pushed
the
ZEPPELIN-1015
branch
from
40d4137 to
ccee60a
Compare
Member
Author
|
Rebased to resolve conflicts to master. |
|
LGTM too, thanks @Leemoonsoo I've also tried with same interpreter and also works |
Member
Author
|
@jmrr Thanks for verifying! |
asfgit
pushed a commit
that referenced
this pull request
Jun 18, 2016
…of interpreter is being used ### What is this PR for? Cron job can fail when notebook uses multiple types of paragraphs. Problem reported here http://apache-zeppelin-users-incubating-mailing-list.75479.x6.nabble.com/Cron-job-fails-to-run-a-paragraph-that-runs-correctly-manually-tt2265.html ### What type of PR is it? Bug Fix ### Todos * [x] - Fix * [x] - Unittest ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1015 ### How should this be tested? Create two paragraphs in the notebook First takes longer than second (last) paragraph. First paragraph and second paragraph should use different interpreter. If cron schedule the notebook with 'auto-restart interpreter on cron execution' checked. Then interpreters will be restarted when second paragraph finished, but first paragraph is still running. That may cause abort of first paragraph run. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #1019 from Leemoonsoo/ZEPPELIN-1015 and squashes the following commits: ccee60a [Lee moon soo] update unittest 9ad4cbb [Lee moon soo] Fix problem by waiting all paragraphs in note be finished (cherry picked from commit c934b3a) Signed-off-by: Lee moon soo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Cron job can fail when notebook uses multiple types of paragraphs.
Problem reported here http://apache-zeppelin-users-incubating-mailing-list.75479.x6.nabble.com/Cron-job-fails-to-run-a-paragraph-that-runs-correctly-manually-tt2265.html
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1015
How should this be tested?
Create two paragraphs in the notebook
First takes longer than second (last) paragraph.
First paragraph and second paragraph should use different interpreter.
If cron schedule the notebook with 'auto-restart interpreter on cron execution' checked.
Then interpreters will be restarted when second paragraph finished, but first paragraph is still running.
That may cause abort of first paragraph run.
Questions: