Skip to content

Conversation

@astroshim
Copy link
Contributor

What is this PR for?

This PR is for blocking unnecessary zeppelin-web build errors.

[ERROR] npm WARN package.json [email protected] No license field.
[ERROR] bower perfect-scrollbar extra-resolution Unnecessary resolution: perfect-scrollbar#~0.5.4

What type of PR is it?

Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1014

How should this be tested?

You can run mvn clean package -DskipTests in the zeppelin-web folder.

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@bzz
Copy link
Member

bzz commented Jun 16, 2016

Is it a build WARNING or an actual error?

Asking as have not seen CI build failure due to this error before

@astroshim
Copy link
Contributor Author

It's not actual error just error messsage.

@corneadoug
Copy link
Contributor

It's not an ERROR and doesn't break the build.
It's more of a warning/info but when running it is shown with [ERROR] which can be misleading when looking for build errors.

I actually get a few more if I clean the repo like a new clone with: git clean -dxf
(Warning, this will wipe out your notebooks and config files)

[ERROR] npm WARN deprecated [email protected]: lodash@<3.0.0 is no longer maintained. Upgrade to lodash@^4.0.0.
[ERROR] npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
[ERROR] npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
[ERROR] npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
[ERROR] npm WARN deprecated [email protected]: the module is now available as 'css-select'
[ERROR] npm WARN deprecated [email protected]: the module is now available as 'css-what'

@corneadoug
Copy link
Contributor

However some of those errors are more related to deprecated versions and might need more tests if we update the dependencies.
Maybe it should be done in a different PR.

@astroshim
Copy link
Contributor Author

@corneadoug Thank you very much for the clarification!

@cloverhearts
Copy link
Member

Looks good! +1

@corneadoug
Copy link
Contributor

Merging if there is no more discussions

@bzz
Copy link
Member

bzz commented Jun 17, 2016

Sounds great, thank you for explanation

@asfgit asfgit closed this in 19c4797 Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants