-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Lens Interpreter #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lens Interpreter #100
Conversation
|
This is really great work! One comment, you probably want to add Lens interpreter in conf/zeppelin-site.xml.template, zeppelin.interpreters property. |
|
@praagarw, Everything looks good and only missing thing i think is adding Please don't worry about code conflict with current master branch. I can take care when merging the code. |
Conflicts: pom.xml zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
|
@Leemoonsoo I added org.apache.zeppelin.lens.LensInterpreter to conf/zeppelin-site.xml.template. Howerver tests are failing. Can you please take this forward. |
Add Lens interpreter. #100 has implementation from praagarw. This pr grabbing a necessary commits from #100 and rebase from current master branch. Author: Pranav Agarwal <[email protected]> Author: Lee moon soo <[email protected]> Closes #114 from Leemoonsoo/ZEPPELIN-61 and squashes the following commits: 0edaf8c [Lee moon soo] Bumpup lens interpreter artifact version adc23f9 [Pranav Agarwal] fixed merge conflicts for conf/zeppelin-site.xml.template 97eb569 [Pranav Agarwal] added lens entry to conf/zeppelin-site.xml.template b81ab78 [Pranav Agarwal] Lens Interpreter
|
getting following error with latest build . |
|
Yep, I'm getting the same on master |
|
Fixed the build failure is pull request #159 |
Add Lens interpreter. apache#100 has implementation from praagarw. This pr grabbing a necessary commits from apache#100 and rebase from current master branch. Author: Pranav Agarwal <[email protected]> Author: Lee moon soo <[email protected]> Closes apache#114 from Leemoonsoo/ZEPPELIN-61 and squashes the following commits: 0edaf8c [Lee moon soo] Bumpup lens interpreter artifact version adc23f9 [Pranav Agarwal] fixed merge conflicts for conf/zeppelin-site.xml.template 97eb569 [Pranav Agarwal] added lens entry to conf/zeppelin-site.xml.template b81ab78 [Pranav Agarwal] Lens Interpreter (cherry picked from commit 1bc5e8d) Signed-off-by: Lee moon soo <[email protected]>
|
@praagarw Could you please this PR? |
No description provided.