Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1912] Upgrade golang dependencies for CVEs #670

Closed
wants to merge 1 commit into from
Closed

[YUNIKORN-1912] Upgrade golang dependencies for CVEs #670

wants to merge 1 commit into from

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Sep 6, 2023

What is this PR for?

golang.org/x/net: need to move to at least 0.13 due to CVEs

Should push all replace ones we use to latest:

golang.org/x/crypto => golang.org/x/crypto v0.12.0
golang.org/x/net => golang.org/x/net v0.14.0
golang.org/x/sys => golang.org/x/sys v0.12.0
golang.org/x/text => golang.org/x/text v0.13.0
golang.org/x/tools => golang.org/x/tools v0.12.0

This needs to be checked against all repos

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1912

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pegasas pegasas changed the title [DRAFT][YUNIKORN-1912] Upgrade golang dependencies for CVEs [YUNIKORN-1912] Upgrade golang dependencies for CVEs Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #670 (7b73254) into master (8b26c37) will increase coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
+ Coverage   71.87%   71.90%   +0.02%     
==========================================
  Files          51       51              
  Lines        8079     8076       -3     
==========================================
  Hits         5807     5807              
+ Misses       2074     2073       -1     
+ Partials      198      196       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants