Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1921] Gang Scheduled Placeholder Pods Don't Inherit Priorit… #657

Closed
wants to merge 2 commits into from

Conversation

manirajv06
Copy link
Contributor

…yClasses

What is this PR for?

Use the priority of the originator pod as the priority for all placeholders.

What type of PR is it?

  • - Bug Fix

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1921

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@manirajv06 manirajv06 self-assigned this Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #657 (b38eccd) into master (ad70954) will increase coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
+ Coverage   71.42%   71.44%   +0.01%     
==========================================
  Files          51       51              
  Lines        8116     8128      +12     
==========================================
+ Hits         5797     5807      +10     
- Misses       2122     2123       +1     
- Partials      197      198       +1     
Files Changed Coverage Δ
pkg/cache/placeholder.go 93.58% <100.00%> (+0.43%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit.

pkg/cache/placeholder.go Outdated Show resolved Hide resolved
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM. E2e test failures are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants