[YUNIKORN-1908] Support GPU in placeholders #651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended resources and huge pages can not over commit. The pod validator checks for a Limit setting in the pod spec. The pod fails validation without it. Placeholder creation must make sure that the pods pass the validator. Set limits for all extended resources and hugepages-* as they cannot be over committed. Clean up of duplicated task group definition in the test.
wilfred-s
requested review from
lixmgl,
craigcondit,
yangwwei,
pbacsko and
0yukali0
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
+ Coverage 71.33% 71.40% +0.06%
==========================================
Files 51 51
Lines 8104 8116 +12
==========================================
+ Hits 5781 5795 +14
+ Misses 2127 2124 -3
- Partials 196 197 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pbacsko
reviewed
Aug 9, 2023
pbacsko
reviewed
Aug 9, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Extended resources and huge pages can not over commit. The pod validator checks for a Limit setting in the pod spec. The pod fails validation without it. Placeholder creation must make sure that the pods pass the validator.
Set limits for all extended resources and hugepages-* as they cannot be over committed.
Clean up of duplicated task group definition in the test.
What type of PR is it?
What is the Jira issue?
How should this be tested?
Unit test added
e2e test for placeholders should be extended but we do not have GPU nodes in kind, follow up jira logged to