[YUNIKORN-1861] add omitempty #647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbacsko
reviewed
Aug 9, 2023
go.mod
Outdated
Comment on lines
25
to
26
| github.com/apache/yunikorn-core v0.0.0-20230801161208-759e14da2966 | ||
| github.com/apache/yunikorn-scheduler-interface v0.0.0-20230731151735-8931af4dda26 |
There was a problem hiding this comment.
@FrankYang0529 could you update this to the latest core/SI?
There was a problem hiding this comment.
Hi @pbacsko, thanks for the review. The error in e2e test needs to update yunikorn-core. I will send a PR to yunikorn-core first and then back to update to the latest version here.
There was a problem hiding this comment.
Wait for PR apache/yunikorn-core#616.
There was a problem hiding this comment.
Updated it. All admission e2e tests can pass on my laptop.
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 71.33% 71.33%
=======================================
Files 51 51
Lines 8104 8104
=======================================
Hits 5781 5781
Misses 2127 2127
Partials 196 196 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I merged apache/yunikorn-core#616. |
Signed-off-by: Frank Yang <[email protected]>
Signed-off-by: Frank Yang <[email protected]>
FrankYang0529
force-pushed
the
YUNIKORN-1861
branch
from
ae194da
to
e5fa564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add
omitemptyto DAO objects in k8shim.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1861
How should this be tested?
Screenshots (if appropriate)
Questions: