-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1687] add e2e for user & group quota enforcement #634
Conversation
63b0109
to
7ff5d37
Compare
@FrankYang0529 How should we take this up? Should we cover all cases described in https://issues.apache.org/jira/browse/YUNIKORN-1871 and plan for review? I think better to cover all the cases and review together. |
Hi @manirajv06, yes, I agree it's better to cover all the cases in this PR. I will update the PR and remove WIP once it's ready for review. I will do my best to finish it this week. Thank you! |
@manirajv06 , I have to create another PR (apache/yunikorn-core#595) for YUNIKORN-1871, because it's unit test in yunikorn-core. I will finish the unit test first and then back to this PR for e2e test. Thank you. |
7ff5d37
to
6663cf6
Compare
6663cf6
to
36edbde
Compare
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
=======================================
Coverage 71.87% 71.87%
=======================================
Files 51 51
Lines 8079 8079
=======================================
Hits 5807 5807
Misses 2074 2074
Partials 198 198 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@FrankYang0529 Now that apache/yunikorn-core#595 has gone in, can you clean up this pr? and also, can you ensure all cases has been covered as e2e tests? |
Hi @manirajv06, sorry for the late reply. I will update test cases in this weekend. Thank you. |
Signed-off-by: PoAn Yang <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
36edbde
to
0d9232d
Compare
Hi @manirajv06, I would like to split wildcard and config change cases to another two Jira, because I don't want to make this PR too big. Thank you. |
Created another two Jira. Thank you.
|
What is this PR for?
What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1687
How should this be tested?
All e2e test cases pass.