[CMSIS-NN] Separated symmetric and asymmetric padding tests for Conv2D #9963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ia73223291680005ac8f9313d7f16a6afcbfb0b18
asparkhi
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
Contributor
Author
|
CC: @Mousius @grant-arm for code review. |
Mousius
requested changes
Jan 19, 2022
| @pytest.mark.parametrize("kernel_size", [(3, 3)]) | ||
| @pytest.mark.parametrize("padding", ["SAME", "VALID"]) | ||
| @pytest.mark.parametrize("strides, dilation", [((1, 1), (1, 1))]) | ||
| @pytest.mark.parametrize("relu_type", ["RELU"]) |
Member
There was a problem hiding this comment.
Make these variables instead of parametrize so it's clear they don't change.
Contributor
Author
There was a problem hiding this comment.
Made the change. Let's see how the checks go.
…ng values Change-Id: I4ec6dd74a4785d16408da04538cb58a07781d788
yuanfz98
pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from [CMSIS-NN] Support for asymmetric padding in Convolutions #9886.