[AMP] Fix IsMixedPrecisionType Edge Case #9856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewZhaoLuo
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Co-authored-by: Cody Yu <[email protected]>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* fix ismixedprecisiontype * fix test * jostle * Update tests/python/relay/test_to_mixed_precision.py Co-authored-by: Cody Yu <[email protected]> Co-authored-by: Cody Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsMixedPrecisionType returns whether the given type matches the target mixed precision type if the type is a floating point type. If it is not a floating point type and the corresponding flag is set it just returns true.
This was the intended behavior. Previously this was not the case. This PR fixes things to match intended behavior.
Motivation is an op with a mix of arguments consisting of floating point and integers would never be allowed to be done in FP16 space unless the integer tensors were also constants.