[ONNX][Relay][Op] Enable Grouped Conv1d #9687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewZhaoLuo
requested review from
Huyuwei,
MarisaKirisame,
ZihengJiang,
anijain2305,
icemelon,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
siju-samuel,
slyubomirsky,
srkreddy1238,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
AndrewZhaoLuo
requested review from
areusch,
comaniac,
merrymercy and
tqchen
as code owners
AndrewZhaoLuo
changed the title
Contributor
|
Thanks for making this change, Andrew. Any chance you could do a quick check on the performance before and after? I worry that without group conv1d schedule support in topi, this will result in a regression. |
Contributor
Author
|
Superseded by #9832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just need to have the type relation support it and it seems to run on llvm target.
Need to check CUDA still.