-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[BugFix] fix nvptx not supported by device_enabled error #9585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ZQPei <[email protected]>
junrushao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Signed-off-by: ZQPei <[email protected]>
|
@junrushao1994 Quoted error is
This error is raised because of tvm/tests/python/unittest/test_tir_ir_builder.py Lines 499 to 552 in 0a4cc89
I have tried to fix it with this commit a8d14b1, and it works fine on my 2080ti gpu card. |
vinx13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codegen fix looks good
|
Yeah I think it's reasonable to handle dynamic shared memory this way for now |
|
Thank you so much for the fix! @ZQPei |
* [BugFix] fix nvptx not supported by device_enabled error Signed-off-by: ZQPei <[email protected]> * [BugFix] shared.dyn support for codegen_nvptx Signed-off-by: ZQPei <[email protected]>
* [BugFix] fix nvptx not supported by device_enabled error Signed-off-by: ZQPei <[email protected]> * [BugFix] shared.dyn support for codegen_nvptx Signed-off-by: ZQPei <[email protected]>
* [BugFix] fix nvptx not supported by device_enabled error Signed-off-by: ZQPei <[email protected]> * [BugFix] shared.dyn support for codegen_nvptx Signed-off-by: ZQPei <[email protected]>
* [BugFix] fix nvptx not supported by device_enabled error Signed-off-by: ZQPei <[email protected]> * [BugFix] shared.dyn support for codegen_nvptx Signed-off-by: ZQPei <[email protected]>
* [BugFix] fix nvptx not supported by device_enabled error Signed-off-by: ZQPei <[email protected]> * [BugFix] shared.dyn support for codegen_nvptx Signed-off-by: ZQPei <[email protected]>
* [BugFix] fix nvptx not supported by device_enabled error Signed-off-by: ZQPei <[email protected]> * [BugFix] shared.dyn support for codegen_nvptx Signed-off-by: ZQPei <[email protected]>
* [BugFix] fix nvptx not supported by device_enabled error Signed-off-by: ZQPei <[email protected]> * [BugFix] shared.dyn support for codegen_nvptx Signed-off-by: ZQPei <[email protected]>
Fix Issue #9513.
I think this bug was mistakenly introduced by #8032.