Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC] support arbitrary input dims for add/mul/relu of dnnl c_src codegen #9127

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

sunwayforever
Copy link
Contributor

[BYOC] support arbitrary input dims for add/mul/relu of dnnl c_src codegen

@sunwayforever sunwayforever changed the title support arbitrary input dims for add/mul/relu of dnnl c_src codegen [BYOC] support arbitrary input dims for add/mul/relu of dnnl c_src codegen Sep 26, 2021
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

src/relay/backend/contrib/dnnl/codegen.cc Show resolved Hide resolved
src/relay/backend/contrib/dnnl/codegen.cc Show resolved Hide resolved
src/runtime/contrib/dnnl/dnnl.cc Outdated Show resolved Hide resolved
@masahi
Copy link
Member

masahi commented Sep 28, 2021

Can you add a test?

@comaniac
Copy link
Contributor

Can you add a test?

Hey @masahi, the DNNL C codegen currently is not enabled in the CI so it won't be tested anyways. The reason we didn't deprecate it is because it is a good codegen example against to the JSON codegen/runtime. Do you have any suggestion for this case?

Copy link
Member

@masahi masahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I think it's fine without a test then.

@masahi masahi merged commit c2bf399 into apache:main Sep 29, 2021
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 29, 2021
* main:
  Fix flaky NMS test by making sure scores are unique (apache#9140)
  [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc (apache#9038)
  [LLVM] Make changes needed for opaque pointers (apache#9138)
  Arm(R) Ethos(TM)-U NPU codegen integration (apache#8849)
  [CI] Split Integration tests out of first phase of pipeline (apache#9128)
  [Meta Schedule][M3b] Runner (apache#9111)
  Fix Google Mock differences between Ubuntu 18.04 and 16.04 (apache#9141)
  [TIR] add loop partition hint pragma (apache#9121)
  fix things (apache#9146)
  [Meta Schedule][M3a] SearchStrategy (apache#9132)
  [Frontend][PyTorch] support for quantized conv_transpose2d op (apache#9133)
  [UnitTest] Parametrized test_conv2d_int8_intrinsics (apache#9143)
  [OpenCL] Remove redundant visit statement in CodeGen. (apache#9144)
  [BYOC] support arbitrary input dims for add/mul/relu of dnnl c_src codegen (apache#9127)
  [Relay][ConvertLayout] Support for qnn.conv2d_transpose (apache#9139)
  add nn.global_avgpool to fq2i (apache#9137)
  [UnitTests] Enable minimum testing on Vulkan target in CI (apache#9093)
  [Torch] Support returning quantized weights and bias for BYOC use cases (apache#9135)
  [Relay] Prepare for new plan_devices.cc (part II) (apache#9130)
  [microTVM][Zephyr] Add MIMXRT1050 board support (apache#9068)
@sunwayforever sunwayforever deleted the dnnl_c_shape branch October 12, 2021 08:17
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
…degen (apache#9127)

* support arbitrary input dims for add/mul/relu of dnnl c_src codegen

* fix lint

* fix

Co-authored-by: sunway <[email protected]>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
…degen (apache#9127)

* support arbitrary input dims for add/mul/relu of dnnl c_src codegen

* fix lint

* fix

Co-authored-by: sunway <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants