Commits on Sep 22, 2021

1. BUG apache#8013: Remove register_alter_op_layout example from dev/use… …

   …_pass_infra.py
   
   This tutorial registers a global layout transformation for conv2d for all
   targets which is not well-formed. Later uses of conv2d in the tutorials
   pick that layout up then assert fail in the conv2d type-relation.
   
   Better would be to register a transform for an entirely fake target, but
   that is beyond my current level of expertise.
   
   In general our use of sphinx/sphinx_gallery for running and rendering the
   tutorials is highly suspect since there is no inter-example isolation:
    - Examples using tensorflow will gobble up GPU memory and not give it back.
    - Any examples which use any of the (many!) global registration mechanisms
      need to ensure the registrant is safe across all tutorials.
   I recall seeing a thread with the sphinx_gallery where they said they'd prefer
   not to work on process-level isolation, but it's probably worth pinging again.
   
   While digging into this I noticed we had a slicing cast in AlterOpLayout due
   to a derived class of ObjectRef introducing virtuals. I moved the virtuals to
   the corresponding Node classes. In this case we got away with it since the
   ObjectRef happened to not get copied but we were on very thin ice.

   

   mbs-octoml committed Sep 22, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 0c85654
   • Browse repository at this point

   Copy the full SHA

   0c85654 View commit details

   Browse the repository at this point in the history

2. [checkpoint] Woops, forgot there was an extra AlterOpLayout …

   I should have run locally, there goes 6hrs of CI.

   

   mbs-octoml committed Sep 22, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for bc96d94
   • Browse repository at this point

   Copy the full SHA

   bc96d94 View commit details

   Browse the repository at this point in the history