[Bugfux] wasm32-standalone app repaired #8563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ya0guang
requested review from
comaniac,
jroesch,
junrushao,
tqchen,
yzhliu and
zhiics
as code owners
tqchen
approved these changes
Jul 26, 2021
Member
leonwanghui
reviewed
Jul 29, 2021
| [dependencies] | ||
| wasmtime = "0.16.0" | ||
| wasmtime-wasi = "0.16.0" | ||
| wasmtime = "0.28.0" |
Contributor
There was a problem hiding this comment.
Can u check it if this version of wasmtime supports loading wasm graph with -mattr=+simd128 flag? Thanks!
Member
Author
There was a problem hiding this comment.
Can u check it if this version of
wasmtimesupports loading wasm graph with-mattr=+simd128flag? Thanks!
Yes. I've already tested it. wasmtime 0.28 supports it.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix the
wasm32-standaloneapp and it works now! Fix #8439wasmtimeAPIs in this example to the latest versiontvm-sys: since there is nolibtvmbuilt inwasm32, then it should not try to linklibtvmwhen buildingwasm32target