Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC][ACL] Prevent dilated pooling #8149

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Conversation

d-smirnov
Copy link
Contributor

This PR adds check preventing avg_pool2d and max_pool2d to be scheduled for execution via ACL* runtime if dilation other than (1, 1) is provided as ACL does not currently support dilation attribute in pooling layer.

*ACL stands for "Compute Library for the Arm® Architecture"

 Added check preventing avg_pool2d and max_pool2d to be
scheduled for execution via ACL* runtime if dilation other
than (1, 1) is provided as ACL does not currently support
dilation attribute in pooling layer.

*ACL stands for "Compute Library for the Arm® Architecture"

Change-Id: If8f65d3a154e09f880bec73dd756d9f985a20ff2
Change-Id: If91809350786e69f59596301e0cbd3def6815cd0
@tqchen
Copy link
Member

tqchen commented Jun 4, 2021

@leandron @mbaret would be great if you can help manage this PR

Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbaret mbaret merged commit 8a0472f into apache:main Jun 11, 2021
@mbaret
Copy link
Contributor

mbaret commented Jun 11, 2021

This is now merged, thanks @d-smirnov!

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
* [BYOC][ACL] Prevent dilated pooling

 Added check preventing avg_pool2d and max_pool2d to be
scheduled for execution via ACL* runtime if dilation other
than (1, 1) is provided as ACL does not currently support
dilation attribute in pooling layer.

*ACL stands for "Compute Library for the Arm® Architecture"

Change-Id: If8f65d3a154e09f880bec73dd756d9f985a20ff2

* linter

Change-Id: If91809350786e69f59596301e0cbd3def6815cd0
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
* [BYOC][ACL] Prevent dilated pooling

 Added check preventing avg_pool2d and max_pool2d to be
scheduled for execution via ACL* runtime if dilation other
than (1, 1) is provided as ACL does not currently support
dilation attribute in pooling layer.

*ACL stands for "Compute Library for the Arm® Architecture"

Change-Id: If8f65d3a154e09f880bec73dd756d9f985a20ff2

* linter

Change-Id: If91809350786e69f59596301e0cbd3def6815cd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants