Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Use take instead of min in NMS conditions #7633

Merged
merged 1 commit into from
Mar 11, 2021
Merged

[ONNX] Use take instead of min in NMS conditions #7633

merged 1 commit into from
Mar 11, 2021

Conversation

masahi
Copy link
Member

@masahi masahi commented Mar 11, 2021 •
edited
Loading

Using min on the output of less ends up allocating shared memory of type bool, which SPIR-V doesn't like.

@mbrookhart

@mbrookhart mbrookhart merged commit f8596b5 into apache:main Mar 11, 2021
@mbrookhart
Copy link
Contributor

Thanks @masahi

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@masahi
[ONNX] Use take instead of min in NMS conditions (apache#7633)
88219b6
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
@masahi @trevor-m
[ONNX] Use take instead of min in NMS conditions (apache#7633)
1b3d00b
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookhart mbrookhart mbrookhart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masahi @mbrookhart