-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend,TOPI] Improve dynamism for BatchMatmul and Dense #7496
Conversation
138f478
to
ea41b92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also cc @kevinthesun @yongwww for checking the tensorflow frontend changes.
Co-authored-by: Cody Yu <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add test cases to cover your changes.
@comaniac Thanks a lot! Test case has been added for the frontend's changes, and the existing test cases can hit the code changes in TOPI(dense and batch_matmul) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @monklof |
* [TOPI] Dense cuda schedule support dynamic dimension * [TOPI] batch_matmul cublas te computation support dynamism * [Frontend] tensorflow frontend: dynamic support for BatchMatmul * [TOPI] nn batch_matmul te computation support dynamism * fix CI * Update python/tvm/topi/nn/batch_matmul.py Co-authored-by: Cody Yu <[email protected]> * Update python/tvm/topi/cuda/batch_matmul.py Co-authored-by: Cody Yu <[email protected]> * remove concat_dynamic_shape function * update topi dense op integer checking * fix ci * Update python/tvm/relay/frontend/tensorflow.py Co-authored-by: Cody Yu <[email protected]> * Update batch_matmul.py * [Frontend] add test for batch_matmul in dynamic shaped case Co-authored-by: Cody Yu <[email protected]>
* [TOPI] Dense cuda schedule support dynamic dimension * [TOPI] batch_matmul cublas te computation support dynamism * [Frontend] tensorflow frontend: dynamic support for BatchMatmul * [TOPI] nn batch_matmul te computation support dynamism * fix CI * Update python/tvm/topi/nn/batch_matmul.py Co-authored-by: Cody Yu <[email protected]> * Update python/tvm/topi/cuda/batch_matmul.py Co-authored-by: Cody Yu <[email protected]> * remove concat_dynamic_shape function * update topi dense op integer checking * fix ci * Update python/tvm/relay/frontend/tensorflow.py Co-authored-by: Cody Yu <[email protected]> * Update batch_matmul.py * [Frontend] add test for batch_matmul in dynamic shaped case Co-authored-by: Cody Yu <[email protected]>
cc @kevinthesun @zhiics
Thanks for @comaniac 's advices, this is the merged pr for #7491 #7492 #7493 #7494