Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC][VitisAI] Fix issue in Vitis AI codegen out tensor names matching & update docs and docker #7350

Merged
merged 10 commits into from
Feb 24, 2021

Conversation

jtuyls
Copy link
Contributor

@jtuyls jtuyls commented Jan 27, 2021

Fix occasional issue in Vitis AI codegen out tensor names matching.
Small updates in Vitis AI docs & demo_vitis_ai docker.

@comaniac @zhiics @anilmartha

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandron
Copy link
Contributor

cc @tqchen as I think it will require a Docker images rebuild

docs/deploy/vitis_ai.rst Outdated Show resolved Hide resolved
docs/deploy/vitis_ai.rst Outdated Show resolved Hide resolved
python/tvm/contrib/target/vitis_ai.py Outdated Show resolved Hide resolved
@jtuyls
Copy link
Contributor Author

jtuyls commented Feb 14, 2021

@comaniac I made some adjustments based on your comments and updated to main to make the tests pass. Could you have another look at this?

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just a nit.

python/tvm/contrib/target/vitis_ai.py Outdated Show resolved Hide resolved
@comaniac comaniac merged commit 1455536 into apache:main Feb 24, 2021
@comaniac
Copy link
Contributor

Thanks @jtuyls @leandron @zhiics

Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
…ng & update docs and docker (apache#7350)

* Fix bug in vitis ai codegen out tensor names matching & update docs & update docker

* Update vitis_ai.rst

* Move gpg-agent package installation to vitis ai core script

* Refactor install_vitis_ai_core script

* Update docs/deploy/vitis_ai.rst

Co-authored-by: Cody Yu <[email protected]>

* Update docs/deploy/vitis_ai.rst

Co-authored-by: Cody Yu <[email protected]>

* Update vitis-ai docs pynq/edge setup & adjustements for comments

* Update python/tvm/contrib/target/vitis_ai.py

Co-authored-by: Cody Yu <[email protected]>

* Reorg Vitis AI dockerfile to make sure gpg-agent is installed before llvm

Co-authored-by: Jorn Tuyls <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
…ng & update docs and docker (apache#7350)

* Fix bug in vitis ai codegen out tensor names matching & update docs & update docker

* Update vitis_ai.rst

* Move gpg-agent package installation to vitis ai core script

* Refactor install_vitis_ai_core script

* Update docs/deploy/vitis_ai.rst

Co-authored-by: Cody Yu <[email protected]>

* Update docs/deploy/vitis_ai.rst

Co-authored-by: Cody Yu <[email protected]>

* Update vitis-ai docs pynq/edge setup & adjustements for comments

* Update python/tvm/contrib/target/vitis_ai.py

Co-authored-by: Cody Yu <[email protected]>

* Reorg Vitis AI dockerfile to make sure gpg-agent is installed before llvm

Co-authored-by: Jorn Tuyls <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants