-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BYOC][VitisAI] Fix issue in Vitis AI codegen out tensor names matching & update docs and docker #7350
[BYOC][VitisAI] Fix issue in Vitis AI codegen out tensor names matching & update docs and docker #7350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @tqchen as I think it will require a Docker images rebuild |
Co-authored-by: Cody Yu <[email protected]>
Co-authored-by: Cody Yu <[email protected]>
@comaniac I made some adjustments based on your comments and updated to main to make the tests pass. Could you have another look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Just a nit.
Co-authored-by: Cody Yu <[email protected]>
…ng & update docs and docker (apache#7350) * Fix bug in vitis ai codegen out tensor names matching & update docs & update docker * Update vitis_ai.rst * Move gpg-agent package installation to vitis ai core script * Refactor install_vitis_ai_core script * Update docs/deploy/vitis_ai.rst Co-authored-by: Cody Yu <[email protected]> * Update docs/deploy/vitis_ai.rst Co-authored-by: Cody Yu <[email protected]> * Update vitis-ai docs pynq/edge setup & adjustements for comments * Update python/tvm/contrib/target/vitis_ai.py Co-authored-by: Cody Yu <[email protected]> * Reorg Vitis AI dockerfile to make sure gpg-agent is installed before llvm Co-authored-by: Jorn Tuyls <[email protected]> Co-authored-by: Cody Yu <[email protected]>
…ng & update docs and docker (apache#7350) * Fix bug in vitis ai codegen out tensor names matching & update docs & update docker * Update vitis_ai.rst * Move gpg-agent package installation to vitis ai core script * Refactor install_vitis_ai_core script * Update docs/deploy/vitis_ai.rst Co-authored-by: Cody Yu <[email protected]> * Update docs/deploy/vitis_ai.rst Co-authored-by: Cody Yu <[email protected]> * Update vitis-ai docs pynq/edge setup & adjustements for comments * Update python/tvm/contrib/target/vitis_ai.py Co-authored-by: Cody Yu <[email protected]> * Reorg Vitis AI dockerfile to make sure gpg-agent is installed before llvm Co-authored-by: Jorn Tuyls <[email protected]> Co-authored-by: Cody Yu <[email protected]>
Fix occasional issue in Vitis AI codegen out tensor names matching.
Small updates in Vitis AI docs & demo_vitis_ai docker.
@comaniac @zhiics @anilmartha
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.