-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource_handle to TVM_DLL_EXPORT_TYPED_FUNC. #7338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In apache#5921, resource_handle was added as a parameter to TVMBackendPackedCFunc, which is the typedef for functions called by LibraryModule's function lookup. * It appears TVM_DLL_EXPORT_TYPED_FUNC was overlooked in that PR, although there don't seem to be any runtime affects known so far. However, making this definition proper to avoid any compiler warnings/debug tool problems. * See also https://discuss.tvm.apache.org/t/rfc-misra-c-changes-for-rpc-support/7098/5
tqchen
approved these changes
Jan 26, 2021
Thanks @jinchenglee @areusch ! |
@areusch , there's another macro in packed_func.h needs same fix. You are actually fixing TVM_DLL_EXPORT_PACKED_FUNC in the commit.
|
@jinchenglee gotcha, do you want to submit a PR? |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* In apache#5921, resource_handle was added as a parameter to TVMBackendPackedCFunc, which is the typedef for functions called by LibraryModule's function lookup. * It appears TVM_DLL_EXPORT_TYPED_FUNC was overlooked in that PR, although there don't seem to be any runtime affects known so far. However, making this definition proper to avoid any compiler warnings/debug tool problems. * See also https://discuss.tvm.apache.org/t/rfc-misra-c-changes-for-rpc-support/7098/5
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* In apache#5921, resource_handle was added as a parameter to TVMBackendPackedCFunc, which is the typedef for functions called by LibraryModule's function lookup. * It appears TVM_DLL_EXPORT_TYPED_FUNC was overlooked in that PR, although there don't seem to be any runtime affects known so far. However, making this definition proper to avoid any compiler warnings/debug tool problems. * See also https://discuss.tvm.apache.org/t/rfc-misra-c-changes-for-rpc-support/7098/5
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* In apache#5921, resource_handle was added as a parameter to TVMBackendPackedCFunc, which is the typedef for functions called by LibraryModule's function lookup. * It appears TVM_DLL_EXPORT_TYPED_FUNC was overlooked in that PR, although there don't seem to be any runtime affects known so far. However, making this definition proper to avoid any compiler warnings/debug tool problems. * See also https://discuss.tvm.apache.org/t/rfc-misra-c-changes-for-rpc-support/7098/5
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* In apache#5921, resource_handle was added as a parameter to TVMBackendPackedCFunc, which is the typedef for functions called by LibraryModule's function lookup. * It appears TVM_DLL_EXPORT_TYPED_FUNC was overlooked in that PR, although there don't seem to be any runtime affects known so far. However, making this definition proper to avoid any compiler warnings/debug tool problems. * See also https://discuss.tvm.apache.org/t/rfc-misra-c-changes-for-rpc-support/7098/5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TVMBackendPackedCFunc, which is the typedef for functions called by
LibraryModule's function lookup.
although there don't seem to be any runtime affects known so
far. However, making this definition proper to avoid any compiler
warnings/debug tool problems.