New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoScheduler] Add custom build function #7185

Merged

FrozenGene merged 6 commits into apache:main from leowang1225:custom-build-func

Jan 5, 2021

Contributor

leowang1225 commented Dec 31, 2020

Signed-off-by: leowang1225 [email protected]

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.


          [AutoScheduler] Add custom build function

d02a266

Signed-off-by: leowang1225 <[email protected]>

Contributor Author

leowang1225 commented Dec 31, 2020

Signed-off-by: leowang1225 [email protected]

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@merrymercy @FrozenGene please help to review!

FrozenGene requested changes

View reviewed changes

python/tvm/auto_scheduler/measure.py Outdated Show resolved Hide resolved

python/tvm/auto_scheduler/measure.py Outdated Show resolved Hide resolved

python/tvm/auto_scheduler/measure.py Outdated Show resolved Hide resolved


          [AutoScheduler] Add custom build function

9e66f14

Signed-off-by: leowang1225 <[email protected]>

jcf94 reviewed

View reviewed changes

python/tvm/auto_scheduler/measure.py

                   """
                   def __init__(self, timeout=15, n_parallel=multiprocessing.cpu_count(), build_func="default"):
-                      self.__init_handle_by_constructor__(_ffi_api.LocalBuilder, timeout, n_parallel, build_func)
+                      if build_func == "default":

Contributor

jcf94 Jan 4, 2021

So this is designed to use the class static member?
Why not just use a self.build_func.

Contributor Author

leowang1225 Jan 4, 2021

when auto_scheduler.local_builder.build is called, the context can't get LocalBuilder class instance

Member

FrozenGene Jan 4, 2021

He should keep the state information of build_func between functions, so just self.build_func can not meet the requirement because we will create one class instance.

Contributor

jcf94 Jan 4, 2021

@FrozenGene @leowang1225
Since we pass the BuildFunc.name to the constructor, how about just register the custom build function by @tvm._ffi.register_func and pass the fuction name to it?
In this way, it can be serialized in args in the local_build_worker below.

jcf94 requested changes

View reviewed changes

python/tvm/auto_scheduler/measure.py Outdated Show resolved Hide resolved

FrozenGene reviewed

View reviewed changes

python/tvm/auto_scheduler/measure.py Show resolved Hide resolved

python/tvm/auto_scheduler/measure.py Outdated Show resolved Hide resolved

leowang1225 added 2 commits

January 4, 2021 14:57


          cheduler] Add custom build function

e3deafb


          [AutoScheduler] Add custom build function

5da7ed7

Signed-off-by: leowang1225 <[email protected]>

FrozenGene reviewed

View reviewed changes

python/tvm/auto_scheduler/measure.py Outdated Show resolved Hide resolved


          [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

FrozenGene approved these changes

View reviewed changes

Member

FrozenGene commented Jan 4, 2021

@jcf94 could you have another one round of review?

jcf94 reviewed

View reviewed changes

python/tvm/auto_scheduler/measure.py

                   """
                   def __init__(self, timeout=15, n_parallel=multiprocessing.cpu_count(), build_func="default"):
-                      self.__init_handle_by_constructor__(_ffi_api.LocalBuilder, timeout, n_parallel, build_func)
+                      if build_func == "default":

Contributor

jcf94 Jan 4, 2021

@FrozenGene @leowang1225
Since we pass the BuildFunc.name to the constructor, how about just register the custom build function by @tvm._ffi.register_func and pass the fuction name to it?
In this way, it can be serialized in args in the local_build_worker below.

python/tvm/auto_scheduler/measure.py Show resolved Hide resolved

Contributor

jcf94 commented Jan 4, 2021

@jcf94 could you have another one round of review?

Sorry for I'm a little busy this afternoon.

jcf94 approved these changes

View reviewed changes

Contributor

jcf94 left a comment

Currently I don't have any better suggestions.

FrozenGene reviewed

View reviewed changes

python/tvm/auto_scheduler/measure.py Outdated Show resolved Hide resolved


          [AutoScheduler] Add custom build function

976caed

Signed-off-by: leowang1225 <[email protected]>

FrozenGene approved these changes

View reviewed changes

FrozenGene merged commit 23bd825 into apache:main

Member

FrozenGene commented Jan 5, 2021

Thanks for the great work @leowang1225 and thanks for the reviewing @jcf94 , it is merged now.

tkonolige pushed a commit to tkonolige/incubator-tvm that referenced this pull request


          [AutoScheduler] Add custom build function (apache#7185)

41ad92d

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* cheduler] Add custom build function

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

masahi pushed a commit to masahi/tvm that referenced this pull request


          [AutoScheduler] Add custom build function (apache#7185)

cbd62b6

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* cheduler] Add custom build function

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request


          [AutoScheduler] Add custom build function (apache#7185)

7fa9b24

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* cheduler] Add custom build function

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

trevor-m pushed a commit to neo-ai/tvm that referenced this pull request


          [AutoScheduler] Add custom build function (apache#7185)

7e14da5

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* cheduler] Add custom build function

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

electriclilies pushed a commit to electriclilies/tvm that referenced this pull request


          [AutoScheduler] Add custom build function (apache#7185)

8f89b42

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* cheduler] Add custom build function

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

* [AutoScheduler] Add custom build function

Signed-off-by: leowang1225 <[email protected]>

junrushao mentioned this pull request

Apache TVM v0.8 Release Note Candidate #9416

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet