Implement Keras Conv1D #7035
Merged
Implement Keras Conv1D #7035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwfromm
reviewed
Dec 4, 2020
| "NCHW", | ||
| "NHWC", | ||
| "NDHWC", | ||
| ], "Layout must be one of 'NWC', 'NCHW', NHWC or NDHWC" |
There was a problem hiding this comment.
looking at this made me realize we should just have 'channels_first' and 'channels_last' as layout options so that it applies to all dimensions. No change needed for this PR but we should keep it in mind as a backlog item to fix.
masahi
approved these changes
Dec 4, 2020
|
Thanks @mbrookhart @jwfromm |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jwfromm @jroesch @masahi