Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC][TRT] Use channels attribute in Conv2D op converter #7011

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

trevor-m
Copy link
Contributor

@trevor-m trevor-m commented Dec 2, 2020

Previous code was getting the number of output channels from the kernel shape, however this didn't work for some grouped convs. Now it will get it from the channels attr of the Relay Conv2D op if available.

Added test case for one such conv2d which failed before.

Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anijain2305 anijain2305 merged commit 0778afd into apache:main Dec 2, 2020
@anijain2305
Copy link
Contributor

Thanks @trevor-m This is merged.

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants