[Relay] Fix a bug in tensor_array_scatter #6890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kevinthesun
previously requested changes
Nov 18, 2020
Member
|
ping @lixiaoquan @kevinthesun please followup |
Contributor
Author
|
@kevinthesun Sorry for late reply, I've enhanced get_name, please take a look. |
Contributor
Author
|
@kevinthesun Could you please take a look again? Thanks |
Member
|
@lixiaoquan please fix the conflict, I'll merge this. |
tensor_array_scatter constructs helper functions according to dtype and shape of element. When there are multiple scatter operations with same dtype and element shape but different indicies_shape, there will be name conflict in prelude.
lixiaoquan
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Contributor
Author
|
@masahi It is rebased, thanks for reviewing |
masahi
approved these changes
Jan 21, 2022
yuanfz98
pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
* [Relay] Fix a bug in tensor_array_scatter tensor_array_scatter constructs helper functions according to dtype and shape of element. When there are multiple scatter operations with same dtype and element shape but different indicies_shape, there will be name conflict in prelude. * Refine get_name
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* [Relay] Fix a bug in tensor_array_scatter tensor_array_scatter constructs helper functions according to dtype and shape of element. When there are multiple scatter operations with same dtype and element shape but different indicies_shape, there will be name conflict in prelude. * Refine get_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tensor_array_scatter constructs helper functions according to dtype
and shape of element. When there are multiple scatter operations with
same dtype and element shape but different indicies_shape, there will
be name conflict in prelude.
@kevinthesun @zhiics Please take a look, thanks.