Skip to content

added support for rocm gpu autodetect #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2017
Merged

added support for rocm gpu autodetect #549

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9da17b
added support for rocm gpu autodetect
Oct 13, 2017
32cc82e
changed type casting from old style to static_cast
Oct 13, 2017
410d0b1
fixed code to generate gfx specific code object
Oct 13, 2017
d9ccda8
fixed namespaces
Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion HalideIR
Open in desktop
Submodule HalideIR updated 3 files
+3 −2 Makefile
+1 −5 src/ir/IRPrinter.cpp
+2 −2 src/tvm/node.h
10 changes: 8 additions & 2 deletions src/codegen/llvm/codegen_amdgpu.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,15 @@ runtime::Module BuildAMDGPU(Array<LoweredFunc> funcs, std::string target) {
CHECK(target.length(
) >= 4 &&
target.substr(0, 4) == "rocm");
TVMContext tvmCtx;
tvmCtx.device_type = kROCM;
tvmCtx.device_id = 0;
TVMRetValue val;
tvm::runtime::DeviceAPI::Get(tvmCtx)->GetAttr(tvmCtx, tvm::runtime::kComputeVersion, &val);
Copy link
Member

@tqchen tqchen Oct 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be safe, I would first query tvm::runtime::DeviceAPI::Get(tvmCtx)->GetAttr(tvmCtx, tvm::runtime::kExist, &val) to check if device exists, then if it exists, append the gfx arch string, otherwise assign an default


llvm::TargetMachine* tm = \
GetLLVMTargetMachine("-mtriple=amdgcn-amd-amdhsa-hcc -mcpu=gfx803" + \
target.substr(4, target.length() - 4));
GetLLVMTargetMachine("-mtriple=amdgcn-amd-amdhsa-hcc -mcpu=gfx" + \
std::to_string(static_cast<int>(val)) + target.substr(4, target.length() - 4));
Copy link
Member

@tqchen tqchen Oct 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::to_string(val.operator int())


std::unique_ptr<CodeGenAMDGPU> cg(new CodeGenAMDGPU());
std::unique_ptr<llvm::LLVMContext> ctx(new llvm::LLVMContext());
Expand Down
6 changes: 5 additions & 1 deletion src/runtime/rocm/rocm_device_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,11 @@ class ROCMDeviceAPI final : public DeviceAPI {
value = 64;
break;
}
case kComputeVersion: return;
case kComputeVersion:
hipDeviceProp_t prop;
ROCM_CALL(hipGetDeviceProperties(&prop, ctx.device_id));
value = prop.gcnArch;
return;
Copy link
Member

@tqchen tqchen Oct 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need break here, note how *rv get assigned in line 53

Copy link
Author

@aditya4d aditya4d Oct 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rookie mistake

}
*rv = value;
}
Expand Down