Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay][Module] Make tags for ADT constructors and ConstructorValues more robust #3369

Merged
merged 8 commits into from
Jul 5, 2019
Merged

[Relay][Module] Make tags for ADT constructors and ConstructorValues more robust #3369

merged 8 commits into from
Jul 5, 2019

Commits on Jun 13, 2019

  1. Use hash of ADT name and constructor idx to generate tag, add reverse… 

    … mapping to module and use where appropriate
    @slyubomirsky
    slyubomirsky committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    8314ee1 View commit details
    Browse the repository at this point in the history

  2. Lint and build fixes

    @slyubomirsky
    slyubomirsky committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    5ce6f63 View commit details
    Browse the repository at this point in the history

  3. Add round-tripping test for getting constructors by tag

    @slyubomirsky
    slyubomirsky committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    ac1ed8c View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. Use int64_t everywhere for tags

    @slyubomirsky
    slyubomirsky committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    4840834 View commit details
    Browse the repository at this point in the history

  2. Add additional identity check

    @slyubomirsky
    slyubomirsky committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    9e35c67 View commit details
    Browse the repository at this point in the history

  3. Bring out _arg_to_ast again

    @slyubomirsky
    slyubomirsky committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    8737357 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2019

  1. Use 8-bit hash of GTV name as MSB of tag, index as LSB for more reada… 

    …ble tags
    @slyubomirsky
    slyubomirsky committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    840ec93 View commit details
    Browse the repository at this point in the history

  2. Use int32 instead of int64 for tag

    @slyubomirsky
    slyubomirsky committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    47ace40 View commit details
    Browse the repository at this point in the history