Skip to content

[RELAY] Filter PlaceholderOp from schedule. #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 4 commits into from
Jan 15, 2019
Merged

[RELAY] Filter PlaceholderOp from schedule. #2412

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4dfbec3
[RELAY] Filter PlaceholderOp from schedule.
srkreddy1238 Jan 10, 2019
4497b31
* test case
srkreddy1238 Jan 14, 2019
e8517eb
* test case
srkreddy1238 Jan 14, 2019
aa77155
* review comments.
srkreddy1238 Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/relay/backend/compile_engine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,18 @@ class ScheduleGetter :
cache_node->func_name = readable_name_stream_.str();
CachedFunc cfunc(cache_node);
CHECK(master_op_.defined());
// Filter PlaceholderOp from the outputs for schedule.
Comment thread
srkreddy1238 marked this conversation as resolved.
Outdated
tvm::Array<Tensor> tensor_outs;
for (const auto& tensor : cache_node->outputs) {
if (!tensor->op.as<PlaceholderOpNode>()) {
tensor_outs.push_back(tensor);
}
}
Schedule schedule;
// No need to register schedule for device copy op.
if (master_attrs_.as<DeviceCopyAttrs>() == nullptr) {
schedule =
fschedule[master_op_](master_attrs_, cache_node->outputs, target_);
fschedule[master_op_](master_attrs_, tensor_outs, target_);
for (const auto& scalar : scalars_) {
schedule[scalar].compute_inline();
}
Expand Down
10 changes: 10 additions & 0 deletions tests/python/relay/test_backend_compile_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,16 @@ def get_func(shape):
y.asnumpy(), x.asnumpy() * 3)
engine.dump()

def test_compile_placeholder_bypass():
engine = relay.backend.compile_engine.get()
x = relay.var("x", shape=(2, 3))
y = relay.var("y", shape=(2, 3))
z = relay.var("z", shape=(2, 3))
result = relay.Tuple([x, relay.op.concatenate([y, z], axis=0)])
func = relay.Function(relay.ir_pass.free_vars(result), result)
with relay.build_config(opt_level=0):
graph, lib, params = relay.build(func, 'llvm')

if __name__ == "__main__":
test_compile_engine()
test_compile_placeholder_bypass()