Skip to content

[Relax][PyTorch] Fix the segfault in from_exported_program when model returns (Tensor, None) tuple #18359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2025
Merged

[Relax][PyTorch] Fix the segfault in from_exported_program when model returns (Tensor, None) tuple #18359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a78fd05
finish1
tlopex Oct 2, 2025
c8503c4
finish2
tlopex Oct 2, 2025
5f8f9d5
add unittest
tlopex Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/tvm/relax/frontend/torch/base_fx_graph_translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ def _retrieve_args(self, node):
return [self._retrieve_args(x) for x in node]
elif isinstance(node, dict):
return {self._retrieve_args(k): self._retrieve_args(v) for k, v in node.items()}
elif node is None:
return relax.op.null_value()
else:
return node

Expand Down
22 changes: 22 additions & 0 deletions tests/python/relax/test_frontend_from_exported_program.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6028,5 +6028,27 @@ def forward(self, x):
np.testing.assert_allclose(pytorch_output2.numpy(), tvm_output2_np, rtol=1e-4, atol=1e-5)


def test_tensor_none_tuple():
example_args = (torch.tensor([1.0, 2.0, 3.0]),)

class TensorNoneModel(Module):
def forward(self, x):
return x + 1, None

@tvm.script.ir_module
class Expected:
@R.function
def main(
x: R.Tensor((3,), dtype="float32")
) -> R.Tuple(R.Tensor((3,), dtype="float32"), R.Object):
with R.dataflow():
lv: R.Tensor((3,), dtype="float32") = R.add(x, R.const(1.0, "float32"))
gv: R.Tuple(R.Tensor((3,), dtype="float32"), R.Object) = (lv, R.null_value())
R.output(gv)
return gv

verify_model(TensorNoneModel(), example_args, {}, Expected)


if __name__ == "__main__":
tvm.testing.main()
Loading