-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[REFACTOR] Transition VisitAttrs to new reflection mechanism in tir/ir_builder/meta_schedule #18096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e10a69 to
750c1f5
Compare
MasterJH5574
approved these changes
Jun 27, 2025
Contributor
|
Curious to learn why we need to refactor this part, and how we can reuse part of the parent class's reflect methods. class SwizzledLayoutNode: LayoutNode {
...
}
# old code with AttrVisitor
void LayoutNode::VisitAttrs(AttrVisitor *v) {
v->Visit("input_size", &input_size_);
v->Visit("forward_index", &forward_index_);
}
void SwizzledLayoutNode::VisitAttrs(tvm::AttrVisitor *v) {
LayoutNode::VisitAttrs(v);
}
# new code
void LayoutNode::RegisterReflection() {
namespace refl = tvm::ffi::reflection;
refl::ObjectDef<LayoutNode>()
.def_ro("input_size", &LayoutNode::input_size)
.def_ro("forward_index", &LayoutNode::forward_index);
}
void SwizzledLayoutNode::RegisterReflection() {
namespace refl = tvm::ffi::reflection;
?
} |
Member
Author
|
The new reflection mechanism would make the field access from python faster (about 10x) because we diretly access the address. In the new code , you just need to do void SwizzledLayoutNode::RegisterReflection() {
namespace refl = tvm::ffi::reflection;
// still need for parent relation to hold, but thats it
refl::ObjectDef<SwizzledLayoutNode>();
}``` |
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…r_builder/meta_schedule (apache#18096) This PR transitions VisitAttrs to new reflection mechansim in the following components: tir, ir_builder, meta_schedule
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
…r_builder/meta_schedule (apache#18096) This PR transitions VisitAttrs to new reflection mechansim in the following components: tir, ir_builder, meta_schedule
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
…r_builder/meta_schedule (apache#18096) This PR transitions VisitAttrs to new reflection mechansim in the following components: tir, ir_builder, meta_schedule
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
…r_builder/meta_schedule (apache#18096) This PR transitions VisitAttrs to new reflection mechansim in the following components: tir, ir_builder, meta_schedule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR transitions VisitAttrs to new reflection mechansim in the following components: tir, ir_builder, meta_schedule