[REFACTOR] Phase out LegacyReprPrinter and improve CommonSubExprElim #18080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
force-pushed
the
legacy-printer
branch
4 times, most recently
from
003163b to
16723ba
Compare
This PR phases out LegacyReprPrinter. Previously common subexpr elim relies on sorting on legacy repr for determism, which is hacky. This PR introduces an ordered_map impl in support to ensure determinism and migrates the CSE pass to use that instead.
MasterJH5574
approved these changes
Jun 19, 2025
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…pache#18080) This PR phases out LegacyReprPrinter. Previously common subexpr elim relies on sorting on legacy repr for determism, which is hacky. This PR introduces an ordered_map impl in support to ensure determinism and migrates the CSE pass to use that instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR phases out LegacyReprPrinter. Previously common subexpr elim relies on sorting on legacy repr for determism, which is hacky.
This PR introduces an ordered_map impl in support to ensure determinism and migrates the CSE pass to use that instead.