Resolving inconsistency between attention/attention_bias #18038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sorry i take a closer look, seems a better fix would be to refactor and remove attention_bias op, and ensure that the attention operator would accept three or four arguments, so it would either take three or four argument here. cc @cyx-6 |
Member
|
actually seems there is a need to introduce attention_bias variant here, so let us first go with this version |
cyx-6
approved these changes
Jun 5, 2025
Contributor
cyx-6
left a comment
cyx-6
left a comment
There was a problem hiding this comment.
Thanks for fixing this! This fix looks good to me.
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
* Resolving inconsistency between attention/attention_bias * reformat * reduce the length of line --------- Co-authored-by: taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given suggestions from Dr. Chen in #17883 , some commits are withdrawn. And #17486 is solved.