[Metal] Fix GetFunction of metal runtime
#18034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug in `MetalModuleNode::GetFunction`. The lambda passed to autoreleasepool is supposed to return nothing. Prior to this PR, it returns a function at an early exit branch, which may cause the error of `EXC_BREAKPOINT` in Metal.
MasterJH5574
force-pushed
the
tvm-dev/2025-06-02-metal-runtime-fix
branch
from
778b0bb to
b49a7e9
Compare
tqchen
approved these changes
Jun 3, 2025
Member
|
@tvm-bot rerun |
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
This PR fixes a bug in `MetalModuleNode::GetFunction`. The lambda passed to autoreleasepool is supposed to return nothing. Prior to this PR, it returns a function at an early exit branch, which may cause the error of `EXC_BREAKPOINT` in Metal.
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
This PR fixes a bug in `MetalModuleNode::GetFunction`. The lambda passed to autoreleasepool is supposed to return nothing. Prior to this PR, it returns a function at an early exit branch, which may cause the error of `EXC_BREAKPOINT` in Metal.
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
This PR fixes a bug in `MetalModuleNode::GetFunction`. The lambda passed to autoreleasepool is supposed to return nothing. Prior to this PR, it returns a function at an early exit branch, which may cause the error of `EXC_BREAKPOINT` in Metal.
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
This PR fixes a bug in `MetalModuleNode::GetFunction`. The lambda passed to autoreleasepool is supposed to return nothing. Prior to this PR, it returns a function at an early exit branch, which may cause the error of `EXC_BREAKPOINT` in Metal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
MetalModuleNode::GetFunction.The lambda passed to autoreleasepool is supposed to return nothing. Prior to this PR, it returns a function at an early exit branch, which may cause the error of
EXC_BREAKPOINTin Metal.