[ARITH] Canonicalize mul-coefficient to rhs #18031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Thanks to @Ghosts381937, supersedes #17765 |
This PR updates the rewrite simplify logic to canonicalize mul-coefficient to rhs. This change is consistent with rest of the code base and allows better simplification of more cases. A test case of floormod with linear offset is added. Co-authored-by: Ghosts381937 <[email protected]>
Member
Author
|
@tvm-bot rerun |
spectrometerHBH
approved these changes
Jun 2, 2025
Ghosts381937
added a commit
to Ghosts381937/tvm
that referenced
this pull request
Jul 17, 2025
* [ARITH] Canonicalize mul-coefficient to rhs This PR updates the rewrite simplify logic to canonicalize mul-coefficient to rhs. This change is consistent with rest of the code base and allows better simplification of more cases. A test case of floormod with linear offset is added. Co-authored-by: Ghosts381937 <[email protected]> * Fix the grad testcase caused by the changed simplification behavior --------- Co-authored-by: Ghosts381937 <[email protected]>
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
* [ARITH] Canonicalize mul-coefficient to rhs This PR updates the rewrite simplify logic to canonicalize mul-coefficient to rhs. This change is consistent with rest of the code base and allows better simplification of more cases. A test case of floormod with linear offset is added. Co-authored-by: Ghosts381937 <[email protected]> * Fix the grad testcase caused by the changed simplification behavior --------- Co-authored-by: Ghosts381937 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the rewrite simplify logic to canonicalize mul-coefficient to rhs. This change is consistent with rest of the code base and allows better simplification of more cases. A test case of floormod with linear offset is added.