[TOPI] Fix index handling in expand_like operator for axis expansion #18006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@tvm-bot rerun! |
Member
Author
|
@tvm-bot rerun |
Member
Author
|
@tvm-bot rerun |
Member
Author
mshr-h
approved these changes
Jun 1, 2025
Contributor
|
@jikechao is that issue happens when apply the schedule or generate the schedule? i mean, if i already tuned the schedule, do i need re-tune the schedule after apply the patch, or just re-generate the model library? |
Member
Author
|
@sunzj, you need not re-tune the schedule after applying this patch. Just regenerating the model library is enough. |
Member
Author
|
@sunzj BTW, this patch specifically addresses a special case: the topi.expand_like operator when a.shape[src_dim] == 1. If your model doesn't encounter this edge case, you can safely ignore this patch, as it won't impact your model's behavior. |
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17947
This PR fixes an index calculation bug in
topi.expand_likewhere incorrect indexing could lead to out-of-bounds access when expanding along specified axes.If
a.shape[src_dim] == 1, we useindice=0because broadcasting rules require replicating the single value across the expanded dimension, and indexing with 0 ensures correct behavior without bounds violations.