Fix FLOP estimation for EvaluateNode by implementing VisitStmt_ handler #17974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
tqchen
approved these changes
May 28, 2025
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…er (apache#17974) Update estimate_flops.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue desription
This pr aimed to fix #17973. MetaSchedule's FLOP estimator fails when encountering EvaluateNode (e.g., from T.call_packed), throwing TVMError: Do not have a default for
tir.Evaluate. This occurs because FlopEstimator lacked a handler for EvaluateNode, causing tuning to abort.Fix strategy
EvaluateNode typically wraps side-effect operations (e.g., T.call_packed for memory copies or external calls) that contribute negligible FLOPs. Returning 0 avoids overcounting while allowing tuning to proceed rather than crash.
cc @Hzfengsy @tqchen @vinx13