Skip to content

[TOPI] Add shape validation to prevent negative dimensions in conv operations #17942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2025
Merged

[TOPI] Add shape validation to prevent negative dimensions in conv operations #17942

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b45db71
add negative output dim checking for conv2d.py
jikechao May 9, 2025
fd4fe6e
Update conv2d.py
jikechao May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/tvm/topi/nn/conv2d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,11 @@ def conv(
dimensions, kernel_dimensions, dilations, pad_begin, pad_end, strides
)
]
for out_dim in out_dimensions:
if isinstance(out_dim, int) and out_dim <= 0:
raise ValueError(
f"Invalid conv parameters: lead to negative output shape {out_dimensions}. "
)
# compute graph
pad_before = list(np.array([0, 0] + pad_begin)[data_permutation_from])
pad_after = list(np.array([0, 0] + pad_end)[data_permutation_from])
Expand Down