[Relax] Handle presence of R.call_tir in MergeCompositeFunctions #17220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, use of `R.call_tir` in the input to `MergeCompositeFunctions` would result in a segfault, when attempting to determine the `Group*` that contains the `relax::GlobalVar` of the callee. This commit updates `MergeCompositeFunctions` to check for `relax::GlobalVar` and `relax::Tuple` instances. Closes apache#17120
tqchen
approved these changes
Jul 31, 2024
Lunderberg
deleted the
bugfix_check_for_global_var_in_merge_composite_functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, use of
R.call_tirin the input toMergeCompositeFunctionswould result in a segfault, when attempting to determine theGroup*that contains therelax::GlobalVarof the callee.This commit updates
MergeCompositeFunctionsto check forrelax::GlobalVarandrelax::Tupleinstances.Closes #17120