[Relax] Update GlobalVar name in AttachGlobalSymbol #17202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `relax.transform.DeadCodeElimination` only considered calls from Relax to TIR when identifying unused functions. This would erroneously remove TIR functions that are called indirectly. This commit adds a new utility `tvm.ir.analysis.collect_call_map`, which can collect the call map of an `IRModule` across both Relax and TIR, using it in Relax's `DeadCodeElimination` transform.
Prior to this commit, the `relax.transform.AttachGlobalSymbol` pass could produce a PrimFunc whose `"global_symbol"` attribute does not match the name of the `GlobalVar`. As a result, the PackedFunc that is provided by the compiled module (defined by the `"global_symbol"`) does not match the PackedFunc that is required by the Relax VM (defined by the `GlobalVar` name). This commit updates `AttachGlobalSymbol` to replace the `GlobalVar` of any function whose `"global_symbol"` is updated. Closes apache#17176
This was referenced Jul 26, 2024
tqchen
approved these changes
Sep 6, 2024
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Sep 10, 2024
This is a follow-up PR to apache#17202, which added a general utility to replace `GlobalVar` instances across all TVM IR types. This PR exposes this new utility through the Python API, and explicitly tests its functionality.
Lunderberg
added a commit
that referenced
this pull request
Sep 12, 2024
* [IR] Expose ReplaceGlobalVars utility in the Python API This is a follow-up PR to #17202, which added a general utility to replace `GlobalVar` instances across all TVM IR types. This PR exposes this new utility through the Python API, and explicitly tests its functionality. * Lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
relax.transform.AttachGlobalSymbolpass could produce a PrimFunc whose"global_symbol"attribute does not match the name of theGlobalVar. As a result, the PackedFunc that is provided by the compiled module (defined by the"global_symbol") does not match the PackedFunc that is required by the Relax VM (defined by theGlobalVarname).This commit updates
AttachGlobalSymbolto replace theGlobalVarof any function whose"global_symbol"is updated.Closes #17176